-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement opr:oscal-version function #1420
Conversation
c4de2fe
to
0a6189a
Compare
871ecb1
to
c37470f
Compare
The opr:oscal-version function meets the "req-meta-oscal-version" requirement from usnistgov#1386. The v:compare utility function helps opr:oscal-version meet the "req-meta-oscalversion-error" requirement.
@david-waltermire-nist , @wendellpiez : I'm taking this pull request out of draft status because I updated the code that compares version strings to handle pre-release identifiers. Please see version_util.xsl. |
See also a question I had in #1437. |
Addresses part of #1440 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very impressive work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Very well tested! Thanks!
The opr:oscal-version function meets the "req-meta-oscal-version" requirement from #1386. The v:compare utility function helps opr:oscal-version meet the "req-meta-oscalversion-error" requirement.
The opr:oscal-version function meets the "req-meta-oscal-version" requirement from #1386. The v:compare utility function helps opr:oscal-version meet the "req-meta-oscalversion-error" requirement.
The opr:oscal-version function meets the "req-meta-oscal-version" requirement from usnistgov#1386. The v:compare utility function helps opr:oscal-version meet the "req-meta-oscalversion-error" requirement.
The opr:oscal-version function meets the "req-meta-oscal-version" requirement from usnistgov#1386. The v:compare utility function helps opr:oscal-version meet the "req-meta-oscalversion-error" requirement.
The opr:oscal-version function meets the "req-meta-oscal-version" requirement from usnistgov#1386. The v:compare utility function helps opr:oscal-version meet the "req-meta-oscalversion-error" requirement.
The opr:oscal-version function meets the "req-meta-oscal-version" requirement from usnistgov#1386. The v:compare utility function helps opr:oscal-version meet the "req-meta-oscalversion-error" requirement.
The opr:oscal-version function meets the "req-meta-oscal-version" requirement from usnistgov#1386. The v:compare utility function helps opr:oscal-version meet the "req-meta-oscalversion-error" requirement.
Committer Notes
This pull request addresses the "Implemented in XSLT profile resolver" part of #1313 and also adds utility functions for working with Semantic Version 2.0.0 strings.
The opr:oscal-version XSLT function meets the "req-meta-oscal-version" requirement
(MUST) from #1386.
The v:compare utility function helps opr:oscal-version meet the
"req-meta-oscalversion-error" requirement.
All Submissions:
"?
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
Changes to Core Features: