Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement opr:oscal-version function #1420

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

galtm
Copy link
Contributor

@galtm galtm commented Aug 21, 2022

Committer Notes

This pull request addresses the "Implemented in XSLT profile resolver" part of #1313 and also adds utility functions for working with Semantic Version 2.0.0 strings.

The opr:oscal-version XSLT function meets the "req-meta-oscal-version" requirement
(MUST) from #1386.

The v:compare utility function helps opr:oscal-version meet the
"req-meta-oscalversion-error" requirement.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

The opr:oscal-version function meets the "req-meta-oscal-version"
requirement from usnistgov#1386.

The v:compare utility function helps opr:oscal-version meet the
"req-meta-oscalversion-error" requirement.
@galtm
Copy link
Contributor Author

galtm commented Aug 30, 2022

@david-waltermire-nist , @wendellpiez : I'm taking this pull request out of draft status because I updated the code that compares version strings to handle pre-release identifiers. Please see version_util.xsl.

@galtm
Copy link
Contributor Author

galtm commented Aug 30, 2022

See also a question I had in #1437.

@galtm
Copy link
Contributor Author

galtm commented Sep 2, 2022

Addresses part of #1440

Copy link
Contributor

@wendellpiez wendellpiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very impressive work!

Copy link
Contributor

@david-waltermire david-waltermire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Very well tested! Thanks!

@david-waltermire david-waltermire merged commit b424536 into usnistgov:develop Sep 27, 2022
aj-stein-nist pushed a commit that referenced this pull request Oct 18, 2022
The opr:oscal-version function meets the "req-meta-oscal-version"
requirement from #1386.

The v:compare utility function helps opr:oscal-version meet the
"req-meta-oscalversion-error" requirement.
david-waltermire pushed a commit that referenced this pull request Oct 31, 2022
The opr:oscal-version function meets the "req-meta-oscal-version"
requirement from #1386.

The v:compare utility function helps opr:oscal-version meet the
"req-meta-oscalversion-error" requirement.
aj-stein-nist pushed a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Jan 10, 2023
The opr:oscal-version function meets the "req-meta-oscal-version"
requirement from usnistgov#1386.

The v:compare utility function helps opr:oscal-version meet the
"req-meta-oscalversion-error" requirement.
aj-stein-nist pushed a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Feb 6, 2023
The opr:oscal-version function meets the "req-meta-oscal-version"
requirement from usnistgov#1386.

The v:compare utility function helps opr:oscal-version meet the
"req-meta-oscalversion-error" requirement.
aj-stein-nist pushed a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Jun 29, 2023
The opr:oscal-version function meets the "req-meta-oscal-version"
requirement from usnistgov#1386.

The v:compare utility function helps opr:oscal-version meet the
"req-meta-oscalversion-error" requirement.
aj-stein-nist pushed a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Jul 10, 2023
The opr:oscal-version function meets the "req-meta-oscal-version"
requirement from usnistgov#1386.

The v:compare utility function helps opr:oscal-version meet the
"req-meta-oscalversion-error" requirement.
aj-stein-nist pushed a commit to galtm/OSCAL that referenced this pull request Sep 28, 2023
The opr:oscal-version function meets the "req-meta-oscal-version"
requirement from usnistgov#1386.

The v:compare utility function helps opr:oscal-version meet the
"req-meta-oscalversion-error" requirement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement SemVer-based comparison on oscal-version in XSLT Profile Resolver
3 participants