-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POAM related finding support, fixes #1120 #1478
POAM related finding support, fixes #1120 #1478
Conversation
…hub.com/Compton-NIST/OSCAL into issue-1120-poam-related-finding-support
…to assessment common from assessment result metaschema.
Important note on this PR, since I realized I needed to adjust slightly: There is the addition of the related-findings assembly, but I also needed to add the findings assembly, similar to the observations and risks assemblies in the POAM. As a part of this, the assessment-result model contained the findings assembly, so I moved that to assessment-common to support both the poam and assessment-result models. |
Co-authored-by: Alexander Stein <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
* Add related finding assembly. #1120 * Add finding assembly to support related-findings, also moved finding to assessment common from assessment result metaschema. * Accept suggestion to revise description. Co-authored-by: Alexander Stein <[email protected]>
* Add related finding assembly. #1120 * Add finding assembly to support related-findings, also moved finding to assessment common from assessment result metaschema. * Accept suggestion to revise description. Co-authored-by: Alexander Stein <[email protected]>
* Add related finding assembly. usnistgov#1120 * Add finding assembly to support related-findings, also moved finding to assessment common from assessment result metaschema. * Accept suggestion to revise description. Co-authored-by: Alexander Stein <[email protected]>
* Add related finding assembly. usnistgov#1120 * Add finding assembly to support related-findings, also moved finding to assessment common from assessment result metaschema. * Accept suggestion to revise description. Co-authored-by: Alexander Stein <[email protected]>
* Add related finding assembly. usnistgov#1120 * Add finding assembly to support related-findings, also moved finding to assessment common from assessment result metaschema. * Accept suggestion to revise description. Co-authored-by: Alexander Stein <[email protected]>
* Add related finding assembly. usnistgov#1120 * Add finding assembly to support related-findings, also moved finding to assessment common from assessment result metaschema. * Accept suggestion to revise description. Co-authored-by: Alexander Stein <[email protected]>
* Add related finding assembly. usnistgov#1120 * Add finding assembly to support related-findings, also moved finding to assessment common from assessment result metaschema. * Accept suggestion to revise description. Co-authored-by: Alexander Stein <[email protected]>
Committer Notes
To match the pattern of POAM for handling observations and risks, a
related-findings
assembly was added.