-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added changes for #1798 #1842
Added changes for #1798 #1842
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please inform FedRAMP that they must impose their (and that of anyone subject to FIPS 199) specific requirement for these FIPS 199/SP 800-60 attributes to be present.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Arminta-Jenkins-NIST can you please review the checklist in the PR template and check it for us? Also, can you rebase this pull request on develop to surpress the CI/CD failure checking an outdated Markdown link:
git checkout 1798-optional-security-sensitivity-level # to be sure
git fetch upstream
git pull -r upstream develop
git push upstream HEAD -f
@aj-stein-nist DONE Here is the result: PS C:\Users\ajj2\git\OSCAL> git push upstream HEAD -f
Everything up-to-date |
Thanks for that update, please also review the checklist with the boxes in the pull request form to let us know what is or is not complete From the PR generated from the template, links to issue completeness guidelines. https://github.com/usnistgov/OSCAL/wiki/Issue-Review#is-the-checklist-list-complete Thanks! |
11dbab4
to
4e114c9
Compare
Committer Notes
Made security-sensitivity-level and security-impact-level optional attributes. Closes #1798.
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)
Changes to Core Features:
Have you written new tests for your core changes, as applicable?Have you included examples of how to use your new feature(s)?Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.