Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax astra-toolbox requirement to >=2.1? #14

Closed
ericpre opened this issue Oct 25, 2024 · 5 comments · Fixed by #20
Closed

Relax astra-toolbox requirement to >=2.1? #14

ericpre opened this issue Oct 25, 2024 · 5 comments · Fixed by #20

Comments

@ericpre
Copy link

ericpre commented Oct 25, 2024

CIL currently supports astra-toolbox >=1.9.9.dev5,<=2.1. Would it be possible to use astra-toolbox 2.1 in etspy?

@AndrewHerzing
Copy link
Collaborator

I have used astra version 2.1.3 with no issues.

@jat255
Copy link
Member

jat255 commented Oct 25, 2024 via email

@jat255
Copy link
Member

jat255 commented Oct 29, 2024

@ericpre after some more investigation, downgrading this dependency causes some headaches on the packaging side of things due to certain versions of astra not being available on PyPI. I'm hopeful that this can be resolved by CIL updating to the latest astra toolbox version without too much trouble.

@ericpre
Copy link
Author

ericpre commented Oct 30, 2024

Thank you @jat255. Maybe I should have be more specific, would it be possible to use astra-toolbox >=2.1 in the dependency requirement, so that CIL and etspy can be install in the same environment after CIL have been installed using conda packages.
The idea would be that etspy can be installed as follow:

  • dependencies from pypi: astra-toolbox 2.2
  • dependencies from conda-forge: astra-toolbox 2.1 (and CIL)

Relaxing dependencies requirement as much as possible is very useful and can avoid a lot of installation trouble.

@jat255
Copy link
Member

jat255 commented Nov 6, 2024

I believe I've sorted this out, and one should now (after the conda packages are built) be able to install etspy alongside astra-toolbox 2.1.2 and numpy 1.26, which should allow for installation with CIL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants