Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better separation of concerns between CommonStack and TomoStack #18

Conversation

jat255
Copy link
Member

@jat255 jat255 commented Nov 4, 2024

Summary of changes:

  • Moved most of the "init" and other TomoStack logic from CommonStack to TomoStack
  • Slicing with a single location with isig now emits a warning, and coerces the shape to (ntilts | 1, y) :
  • Added an extract_sinogram() method that supports both integer and float-based indexing
  • Fixed some axes-handling issues that were causing tests to fail.

AndrewHerzing and others added 24 commits November 1, 2024 09:34
- implement "extract_sinogram" (needs tests)
- fix failing test due to string reformatting
Clean up axes testing/naming logic and add tests for coverage on this
Fix signal_type on extract_sinogram
Add tests for extract_sinogram
add navigation dimension check for recstack
add recstack creation tests
@jat255 jat255 marked this pull request as draft November 4, 2024 21:21
@jat255
Copy link
Member Author

jat255 commented Nov 4, 2024

Actually, I need to update the notebook for these changes.

loosen RecStack navigation limit since it was causing error
in hs.plot.plot_images
update example notebook
@jat255 jat255 force-pushed the Separate-inits-for-RecStack-and-TomoStack branch from 168a8fd to f095397 Compare November 4, 2024 22:02
@jat255 jat255 marked this pull request as ready for review November 4, 2024 22:23
@jat255
Copy link
Member Author

jat255 commented Nov 4, 2024

Ok, I think is is ready again. Updated documentation (specifically the notebook updated with extract_sinogram) is viewable here: https://jat255.github.io/etspy/examples/etspy_demo.html#plot-single-image-alongside-the-sinogram-of-the-central-slice

@AndrewHerzing AndrewHerzing merged commit e39b5ad into usnistgov:master Nov 5, 2024
15 checks passed
@jat255 jat255 deleted the Separate-inits-for-RecStack-and-TomoStack branch November 5, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants