-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better separation of concerns between CommonStack and TomoStack #18
Merged
AndrewHerzing
merged 26 commits into
usnistgov:master
from
jat255:Separate-inits-for-RecStack-and-TomoStack
Nov 5, 2024
Merged
Better separation of concerns between CommonStack and TomoStack #18
AndrewHerzing
merged 26 commits into
usnistgov:master
from
jat255:Separate-inits-for-RecStack-and-TomoStack
Nov 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- implement "extract_sinogram" (needs tests) - fix failing test due to string reformatting
Clean up axes testing/naming logic and add tests for coverage on this Fix signal_type on extract_sinogram Add tests for extract_sinogram
add navigation dimension check for recstack add recstack creation tests
fix tests to match
3 tasks
Actually, I need to update the notebook for these changes. |
loosen RecStack navigation limit since it was causing error in hs.plot.plot_images update example notebook
jat255
force-pushed
the
Separate-inits-for-RecStack-and-TomoStack
branch
from
November 4, 2024 22:02
168a8fd
to
f095397
Compare
Ok, I think is is ready again. Updated documentation (specifically the notebook updated with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
CommonStack
toTomoStack
isig
now emits a warning, and coerces the shape to(ntilts | 1, y)
:extract_sinogram()
method that supports both integer and float-based indexing