Skip to content

Commit

Permalink
Fix calling get_attribute_names on committed datatype
Browse files Browse the repository at this point in the history
  • Loading branch information
axelboc committed Sep 2, 2024
1 parent f349206 commit 0dd3284
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Changelog
## v0.7.8 TBC
### Fixed
- Fix accessing attributes of committed datatype with `my_datafile.attrs`.
- Fix calling `get_attribute_names` method of Module API on committed datatype.
### Changed
- Mark optional parameters as such in the TypeScript declarations of the following `H5Module` methods: `open`, `create_dataset`, `create_group`, `create_vlen_str_dataset` and `get_keys_vector`.
## v0.7.7 2024-08-28
Expand Down
4 changes: 4 additions & 0 deletions src/hdf5_util.cc
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,10 @@ val get_attribute_names(hid_t loc_id, const std::string& obj_name_string)
{
ocpl_id = H5Gget_create_plist(obj_id);
}
else if (obj_type == H5O_TYPE_NAMED_DATATYPE)
{
ocpl_id = H5Tget_create_plist(obj_id);
}
else
{
ocpl_id = H5Dget_create_plist(obj_id);
Expand Down

0 comments on commit 0dd3284

Please sign in to comment.