Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark optional parameters in H5Module interface #83

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

axelboc
Copy link
Collaborator

@axelboc axelboc commented Aug 29, 2024

No description provided.

@axelboc axelboc requested a review from bmaranville August 29, 2024 11:57
Copy link
Member

@bmaranville bmaranville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for catching this.

@bmaranville
Copy link
Member

Do you want another release with these changes, or can it wait until some feature changes in the future?

@axelboc
Copy link
Collaborator Author

axelboc commented Aug 29, 2024

It can wait, no worries 😉 - sorry forgot to update the CHANGELOG, I'll do it now

@axelboc
Copy link
Collaborator Author

axelboc commented Aug 29, 2024

Done 😊

@bmaranville bmaranville merged commit a7bc6b4 into usnistgov:main Sep 2, 2024
1 check passed
@axelboc axelboc deleted the patch-1 branch September 3, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants