-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve validation api #368
Open
david-waltermire
wants to merge
12
commits into
usnistgov:develop
Choose a base branch
from
GSA:feature-refactor-validation-api
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Improve validation api #368
david-waltermire
wants to merge
12
commits into
usnistgov:develop
from
GSA:feature-refactor-validation-api
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aces and to simplify and align implementations.
* Completed code to support Metapath array construction. * Implemented array postfix and unary lookups. * Cleaned up ISequence implementations, moving getFirstItem to be a method member. Added a utility function to convert a sequence into an array member. * Added support for the following Metapath functions: - array:get - array:put - array:append - array:subarray - array:remove - array:insert-before - array:join - array:head - array:tail - array:reverse - array:flatten * Fixed spotbugs null check warnings * Cleaned up some Javadocs. * Incorporated changes based on CodeRabbit review. * normalized line endings
* Added initial implementation of the 'metaschema-cli metapath list-functions' command. * Added a better means to collect the metaschema-related CLI commands for reuse.
… returns the root node when getValue is called.
- Support for map construction. - Added support for maps in function call, postfix and unary lookups. - Added support and unit tests for the following Metapath functions: - map:get - map:merge - map:entry - map:size - map:keys - map:contains - map:find - map:put - map:remove - Added missing characteristics on a number of existing Metapath functions. - Cleaned up a bunch of PMD warnings.
…function signatures now instead of the Java class name.
… use. Improved abstract CLI validation commands to provide more options for model detection.
This was referenced Jun 20, 2024
8 tasks
This should be merged using "rebase and merge" to avoid merge conflicts in downstreams. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Notes
Refactored the Metaschema validation API to allow for more flexibility in use. Improved abstract CLI validation commands to provide more options for model detection.
This PR depends on #367, which should be merged before this PR.
All Submissions:
Changes to Core Features: