Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax Schematron Checks #344

Conversation

aj-stein-nist
Copy link
Collaborator

@aj-stein-nist aj-stein-nist commented Apr 4, 2023

Committer Notes

To allow for backporting certain metaschemas for an upstream OSCAL release drafted before these Schematron rules were added, make them warnings and not errors, so they do not fail CI/CD. Also this way we discourage time travel.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website](https://pages.nist.gov/metaschema) and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.

To allow for backporting certain metaschemas for an upstream OSCAL
release drafted before these Schematron rules were added, make them
warnings and not errors, so they do not fail CI/CD. Also this way we
discourage time travel.
@aj-stein-nist aj-stein-nist self-assigned this Apr 4, 2023
Copy link
Collaborator

@david-waltermire david-waltermire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. These are editorial warnings in nature.

@david-waltermire david-waltermire merged commit b5bbd5b into usnistgov:develop Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants