Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix branch checks for content publication CI/CD. #118

Merged

Conversation

aj-stein-nist
Copy link
Contributor

@aj-stein-nist aj-stein-nist commented Jul 14, 2022

Committer Notes

This is a short-term fix to #117 until #116 lands as a more systemic fix.

A test merge and completed run of this minor CI/CD tweak in my main branch of my developer fork can be found in aj-stein-nist/oscal-content@bfe21e1. This is workflow run to validate this change will publish accordingly.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?

@aj-stein-nist aj-stein-nist added bug The issue is a bug report. Scope: CI/CD A task issue to modify the repo's continuous integration and continuous deployment capability. labels Jul 14, 2022
@aj-stein-nist aj-stein-nist self-assigned this Jul 14, 2022
@aj-stein-nist aj-stein-nist linked an issue Jul 14, 2022 that may be closed by this pull request
@aj-stein-nist aj-stein-nist force-pushed the 117-part-id-mismatch-between-source-and-content branch from bfe21e1 to b0c14d9 Compare July 14, 2022 19:45
@aj-stein-nist aj-stein-nist marked this pull request as ready for review July 14, 2022 21:39
@aj-stein-nist
Copy link
Contributor Author

@david-waltermire-nist this is good to go, I didn't understand why auto-publish was still skipped in this job run but it is because (as I learned debug mode) that I cannot set HOME_REPO in the PR and not invalidate the PR to show a valid test. It should now work though!

Copy link
Contributor

@david-waltermire david-waltermire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@david-waltermire david-waltermire merged commit 243f4fd into main Jul 14, 2022
@david-waltermire david-waltermire deleted the 117-part-id-mismatch-between-source-and-content branch July 14, 2022 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug report. Scope: CI/CD A task issue to modify the repo's continuous integration and continuous deployment capability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Part ID mismatch between source and content
2 participants