PacketList で使える packet の型を任意にする #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meltingrabbit
added
enhancement
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
meltingrabbit
force-pushed
the
feature/delete_ctcp_typedef
branch
from
2c0d599 to
9470fc2
Compare
meltingrabbit
force-pushed
the
feature/update_pl_to_compatible_with_any_packet
branch
from
81e043e to
1e7bad1
Compare
meltingrabbit
force-pushed
the
feature/update_pl_to_compatible_with_any_packet
branch
from
b1b7ae6 to
08f9903
Compare
|
あ～～～～．．．． PL って，CDISとも結合してるじゃんかぁ．．．．． う～む，，，，これ，さすがにPR分けるかぁ．．． |
meltingrabbit
changed the title
|
これでいいでしょう． WIP外しました．レビュー頼みます． |
|
ん～～～，SILS動かなくなったんで，どっか本質的に死んでそう．．．．調査します． |
|
バグ修正したので，test回してます．これで大丈夫そうです． |
meltingrabbit
force-pushed
the
feature/delete_ctcp_typedef
branch
from
9470fc2 to
d06c4d2
Compare
|
依存 PR ( #209 ) がマージされたので， rebase |
meltingrabbit
force-pushed
the
feature/update_pl_to_compatible_with_any_packet
branch
from
da142a2 to
66d95d7
Compare
meltingrabbit
changed the base branch from
feature/delete_ctcp_typedef
to
develop
|
#210 がマージされたので，再度 rebase |
meltingrabbit
force-pushed
the
feature/update_pl_to_compatible_with_any_packet
branch
from
66d95d7 to
46bb230
Compare
yngyu
reviewed
Jan 26, 2022
yngyu
approved these changes
Jan 26, 2022
meltingrabbit
deleted the
feature/update_pl_to_compatible_with_any_packet
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
PacketList で使える packet の型を任意にする
Issue
詳細
検証結果
既存のCIがすべて通ればOK
影響範囲
PL の使い方が変わる．
備考
CommandDispatcherに依存があるので，これは別PRにわけるdevelopに差し替えること！！！