Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

general な OK, NG enum の追加（Rust でいう Result） #504

Merged
merged 2 commits into from
Mar 4, 2023
Merged

general な OK, NG enum の追加（Rust でいう Result） #504

merged 2 commits into from
Mar 4, 2023

Conversation

meltingrabbit
Copy link
Collaborator

概要

general な OK, NG enum の追加（Rust でいう Result）

Issue

詳細

Issue 参照

検証結果

CI が通ればOK

@meltingrabbit meltingrabbit added enhancement New feature or request priority::high priorityg high labels Mar 1, 2023
@meltingrabbit meltingrabbit self-assigned this Mar 1, 2023
@meltingrabbit meltingrabbit mentioned this pull request Mar 1, 2023
Merged
@meltingrabbit meltingrabbit requested a review from flap1 March 1, 2023 18:23
@sksat
Copy link
Collaborator

sksat commented Mar 2, 2023

Rust でいう Result というか，Result<(), ()> ですね．とはいえ無いよりはあった方がいいし，真の Result は C では実装不可能に近いのでよさそう．

meltingrabbit
meltingrabbit commented Mar 2, 2023
View reviewed changes
Library/result.h Outdated Show resolved Hide resolved
sksat
sksat reviewed Mar 2, 2023
View reviewed changes
Library/result.h Outdated Show resolved Hide resolved
@meltingrabbit meltingrabbit requested a review from sksat March 2, 2023 11:52
@meltingrabbit
Copy link
Collaborator Author

@sksat 修整大丈夫そうなら approve ほしい！

@meltingrabbit meltingrabbit merged commit e03ee3d into develop Mar 4, 2023
@meltingrabbit meltingrabbit deleted the feature/result_enum branch March 4, 2023 06:16
@meltingrabbit meltingrabbit mentioned this pull request Mar 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sksat sksat sksat approved these changes

@chutaro chutaro chutaro approved these changes

@ToshiAki64 ToshiAki64 Awaiting requested review from ToshiAki64

@flap1 flap1 Awaiting requested review from flap1

Assignees

@meltingrabbit meltingrabbit

Labels
enhancement New feature or request priority::high priorityg high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meltingrabbit @sksat @chutaro