Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify to suit with S2E-CORE Coding rule #77

Merged
merged 48 commits into from
Oct 11, 2023
Merged

Modify to suit with S2E-CORE Coding rule #77

merged 48 commits into from
Oct 11, 2023

Conversation

200km
Copy link
Member

@200km 200km commented Oct 6, 2023

Issue

詳細

I modified to suit with S2E-CORE Coding rule.
I modified typos.

検証結果

See CI result.

補足

NA

200km added 30 commits October 6, 2023 10:34
@200km
Fix main file
a9eebfb
@200km
Fix comment
c3d6727
@200km
Fix case
4024e7c
@200km
Fix case.h to case.hpp
48b8f5b
@200km
Fix port_config.h to port_config.hpp
ad2e10c
@200km
Fix components.h to components.hpp
0cb5976
@200km
Modify aocs module components
ab42138
@200km
Fix satellite.h to satellite.hpp
5691a44
@200km
Fix CRC
96e9be1
@200km
Fix cmd_size
3992603
@200km
Fix count for MainRoutine
06ed40f
@200km
Fix clock_gen
65a9905
@200km
Fix format
aedf1bb
@200km
Fix INA260 class name
2564a05
@200km
Fix INA260 enum class name
e43cc77
@200km
Fix STIM210 class name
1758174
@200km
Fix RW0003 class name
60ee5ec
@200km
Fix i2c_addr
13bebce
@200km
Fix typo
08578c9
@200km
Fix typo
a7ebd40
@200km
Fix local variables name in RW
cfe4595
@200km
Fix RM3100 class name
3432567
@200km
Fix mag_sensor
0632f9b
@200km
Fix variables name
77e325a
@200km
Fix ORM7600 class name
d8c28de
@200km
Fix ORM7600 variables name
88e9b44
@200km
Fix typo
df0b341
@200km
Fix ORM7600 function name
6542000
@200km
Fix NanoSSOC class name
a68e799
@200km
Fix NanoSSOC variable name
cc3e57e
@200km 200km added 📓 documentation Improvements or additions to documentation ✈️ priority::medium priority medium 🐳 major update Major update labels Oct 6, 2023
@200km 200km added this to the Major update v5.0.0 milestone Oct 6, 2023
@200km 200km self-assigned this Oct 6, 2023
@200km 200km requested review from sksat and a team as code owners October 6, 2023 12:02
@200km 200km requested review from suzuki-toshihir0, t-hosonuma and conjikidow and removed request for a team October 6, 2023 12:02
@200km 200km changed the base branch from develop to feature/add-command-sender October 6, 2023 12:03
suzuki-toshihir0
suzuki-toshihir0 approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@suzuki-toshihir0 suzuki-toshihir0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ざっと確認しましたが，問題なさそうです．

@200km 200km linked an issue Oct 11, 2023 that may be closed by this pull request
Coding ruleをS2E-COREと合わせる #71
Closed
Base automatically changed from feature/add-command-sender to develop October 11, 2023 08:03
@200km 200km merged commit 429942b into develop Oct 11, 2023
@200km 200km deleted the feature/modify-coding-rule branch October 11, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sksat sksat sksat approved these changes

@suzuki-toshihir0 suzuki-toshihir0 suzuki-toshihir0 approved these changes

@t-hosonuma t-hosonuma Awaiting requested review from t-hosonuma t-hosonuma is a code owner automatically assigned from ut-issl/aocs

@conjikidow conjikidow Awaiting requested review from conjikidow conjikidow is a code owner automatically assigned from ut-issl/aocs

Assignees

@200km 200km

Labels
✈️ priority::medium priority medium 📓 documentation Improvements or additions to documentation 🐳 major update Major update
Projects
None yet
Milestone
Major update v5.0.0
Development

Successfully merging this pull request may close these issues.

Coding ruleをS2E-COREと合わせる
3 participants
@200km @sksat @suzuki-toshihir0