generated from ut-issl/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add noise characteristics of the qpd sensor #82
Merged
TomokiMochizuki
merged 15 commits into
ut-issl:develop
from
TomokiMochizuki:feature/add_noise_of_qpd_sensor
Jan 13, 2024
Merged
Add noise characteristics of the qpd sensor #82
TomokiMochizuki
merged 15 commits into
ut-issl:develop
from
TomokiMochizuki:feature/add_noise_of_qpd_sensor
Jan 13, 2024
+104
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomokiMochizuki
changed the title
Add noise characteristics of qpd sensor
Add noise characteristics of the qpd sensor
Jan 10, 2024
200km
reviewed
Jan 11, 2024
s2e-ff/data/initialize_files/components/qpd_positioning_sensor.ini
Outdated
Show resolved
Hide resolved
s2e-ff/data/initialize_files/components/qpd_positioning_sensor.ini
Outdated
Show resolved
Hide resolved
200km
reviewed
Jan 12, 2024
|
||
// Noise parameters | ||
libra::NormalRand qpd_sensor_output_random_noise_; //!< Normal random for QPD sensor output value | ||
double qpd_standard_deviation_scale_factor_m_; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[NITS] コメントをお願いします。
s2e-ff/data/initialize_files/components/qpd_positioning_sensor.ini
Outdated
Show resolved
Hide resolved
double temp = qpd_sensor_sensitivity_coefficient_V_W_ * | ||
laser_emitter->CalcIntensity_W_m2(distance_from_beam_waist_m, deviation_from_optical_axis_m) * qpd_sensor_integral_step_m_ * | ||
qpd_sensor_integral_step_m_; | ||
double temp1 = qpd_sensor_sensitivity_coefficient_V_W_ * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[NITS] temp
という変数名だとどんな計算かわからないので、せめてコメントなどでコードの意図がわかるようにしてもらいたいです。
200km
approved these changes
Jan 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
Add noise characteristics of qpd sensor
Issue
詳細
Add noise characteristics of qpd sensor
検証結果
四分割センサの出力値の履歴
実際の変位と観測した位置変位の履歴
[注意]: 位置変位誤差があるのは、衛星間距離が10mなのに対し、現在位置観測を逆算する際に使用している値が衛星間距離1.5mの時の値であるため.
位置変位の観測誤差の履歴
影響範囲
XX系の動作がガラッと変わる,とか.
補足
何かあれば
注意
priority
ラベルを付けること