Add support for subpaths #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Confirmed that this change builds a website that works fine here: https://civictechto.github.io/polis-storybook/ (unlike how it was broken earlier) Added tests to validate it works. Lemme know if it looks good, and I'll add some docs :) |
utarwyn
approved these changes
Oct 10, 2024
utarwyn
added
bug
|
Thanks! Am happy to document this tonight or tomorrow (or can be separate PR if you merge before I find time) |
|
Ok, added some documentation on subpath hosting to the bottom of the README. Lemme know if you need anything else, but am otherwise considering this complete :) Thanks again for the encouragement! EDIT: I pushed those changes to generateLink as well (mentioned in code review comment) |
…e no longer needed.
utarwyn
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #9
Not documented yet, but only because I'm suspicious I solved it in the wrong way. Avoiding location.pathname.replace() in favour of just returnin
/${target}/seems to resolve the issue as I've added tests for. The tests only broke with the logic we had before.Will try on an actual site, but hoping this resolves the issue!