remove the ssl-certs dir volume #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were adding the vault ca cert to the root ca bundle for two reasons: - To workaround this issue with raft join: hashicorp/vault#7269 - To make things simpler when manually bootstrapping vault by removing the need to specify the path to the ca cert on the command line Now that we're automatically bootstrapping the cluster and the issue is fixed, we can get rid of it.
george-angel
approved these changes
Feb 18, 2020
hectorhuertas
approved these changes
Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were adding the vault ca cert to the root ca bundle for two reasons:
Now that we're automatically bootstrapping the cluster and the issue is fixed, we can get rid of it.