Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add about page #70

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

RNAdvani
Copy link
Contributor

Description

Adds about page

Fixes #33

Type of Change

  • Bug fix
  • New feature
  • Test update
  • Refactor
  • Breaking change
  • Documentation update

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have made corresponding changes to the documentation (README, CONTRIBUTING, etc).
  • I added a new Library/Dependency and have updated the README.
  • I have added tests that prove my fix is effective or that my feature works.
  • My changes generate no new warnings or errors.
  • New and existing unit tests pass locally with my changes.

Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for color-conjure ready!

Name Link
🔨 Latest commit 1da818f
🔍 Latest deploy log https://app.netlify.com/sites/color-conjure/deploys/671940bb78e44f0008aa6486
😎 Deploy Preview https://deploy-preview-70--color-conjure.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@RNAdvani
Copy link
Contributor Author

@utk09-NCL

@RNAdvani
Copy link
Contributor Author

also @utk09-NCL before you merge the pr it would be great if you add a level label to the issue and then merge

@utk09-NCL
Copy link
Owner

what do you mean level label?

SiVitest,
} from "react-icons/si";

export default function Component() {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't name it Component, name it same as the filename

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes changing and pushing again

Copy link
Owner

@utk09-NCL utk09-NCL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the review comments

@RNAdvani
Copy link
Contributor Author

what do you mean level label?

like add a label with level1, level2 based on the tasks you have assigned to me as I'm a gssoc contributor, it would be of great help to me

@utk09-NCL
Copy link
Owner

Please don't push now @RNAdvani
See the updates on README

NOTE - CODEBASE IS CURRENTLY BEING UPDATED FROM JAVASCRIPT TO TYPESCRIPT. PLEASE REFRAIN FROM RASING ANY PR'S TILL SUNDAY 16:00 GMT

Also, I don't really know if I can assign level labels, and I'm not even sure if this has been accepted in gssoc (definitely accepted to hactoberfest though)

@RNAdvani
Copy link
Contributor Author

Please don't push now @RNAdvani See the updates on README

NOTE - CODEBASE IS CURRENTLY BEING UPDATED FROM JAVASCRIPT TO TYPESCRIPT. PLEASE REFRAIN FROM RASING ANY PR'S TILL SUNDAY 16:00 GMT

Also, I don't really know if I can assign level labels, and I'm not even sure if this has been accepted in gssoc (definitely accepted to hactoberfest though)

okay, i wont push, and ig you probably can assign level tags
image

@RNAdvani
Copy link
Contributor Author

RNAdvani commented Oct 26, 2024

these are rules for the gssoc points system @utk09-NCL

@utk09-NCL
Copy link
Owner

Yes, but can you check if this repo is accepted in gssoc?

@RNAdvani
Copy link
Contributor Author

yes it is, your repo is accepted i checked it

@utk09-NCL
Copy link
Owner

I can't find it, can you share a screenshot or something please? Are we looking at two different things? 😅

@RNAdvani
Copy link
Contributor Author

yes here is the screenshot
image

@utk09-NCL
Copy link
Owner

That's just the topic, but I think this repo is not listed on https://gssoc.girlscript.tech/project which I got to know recently. Sorry about that, but I thought the process was same as hacktoberfest. But apparently for gssoc, I needed to register the repo 2 months ago (when this project did not exist 😞)

@RNAdvani
Copy link
Contributor Author

correct, it's okay I'll still contribute to this loved working with you on this

@utk09-NCL
Copy link
Owner

Thanks @RNAdvani Appreciate the gesture and all your (past and future) contributions! 😄

@utk09-NCL
Copy link
Owner

The project has been updated to use Typescript, please pull the latest main and create a new branch with your changes (if that's easier). Thank you for understanding!

@RNAdvani
Copy link
Contributor Author

yes i would

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: 26 - Add About page
2 participants