Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:16(footer):Added a footer component #72

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

samorobo
Copy link

Description

I added a footer components and shared it in the app.jsx file so that its can be available throughout the future routes and pages of this project. And i also installed react-icons using "npm install react-icons". I used the github icon from this installed package when writing the code in my footer components

Fixes #30

Type of Change

  • Bug fix
  • New feature
  • Test update
  • Refactor
  • Breaking change
  • Documentation update

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have made corresponding changes to the documentation (README, CONTRIBUTING, etc).
  • I added a new Library/Dependency and have updated the README.
  • I have added tests that prove my fix is effective or that my feature works.
  • My changes generate no new warnings or errors.
  • New and existing unit tests pass locally with my changes.

Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for color-conjure ready!

Name Link
🔨 Latest commit e14286d
🔍 Latest deploy log https://app.netlify.com/sites/color-conjure/deploys/671b9597c9e73d0008ae37b1
😎 Deploy Preview https://deploy-preview-72--color-conjure.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@samorobo
Copy link
Author

@utk09-NCL i have added the footer pull request, please review and merged

@@ -39,6 +40,7 @@ function App() {
{/* Render toast notifications */}
<Toaster />
<RouterProvider router={router} />
<Footer />
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adding it here, you can add it in <Layout> component

Copy link
Owner

@utk09-NCL utk09-NCL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please rename to Footer
  2. Please add unit tests

@utk09-NCL
Copy link
Owner

The project has been updated to use Typescript, please pull the latest main and create a new branch with your changes (if that's easier). Thank you for understanding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: 16 - Add a footer to the website
2 participants