-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:16(footer):Added a footer component #72
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for color-conjure ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@utk09-NCL i have added the footer pull request, please review and merged |
@@ -39,6 +40,7 @@ function App() { | |||
{/* Render toast notifications */} | |||
<Toaster /> | |||
<RouterProvider router={router} /> | |||
<Footer /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of adding it here, you can add it in <Layout>
component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please rename to Footer
- Please add unit tests
The project has been updated to use Typescript, please pull the latest |
Description
I added a footer components and shared it in the app.jsx file so that its can be available throughout the future routes and pages of this project. And i also installed react-icons using "npm install react-icons". I used the github icon from this installed package when writing the code in my footer components
Fixes #30
Type of Change
Checklist