Feat: Dependency Injection & Hooks #18
Conversation
src/CLI/CLI.php
Outdated
| */ | ||
| public function getResource(string $name, bool $fresh = false): mixed | ||
| { | ||
| if ($name === 'utopia') { |
There was a problem hiding this comment.
I think this was designed against a memory leak. Is it relevant in this context? Should we prevent the CLI instance as a nested dependency itself?
There was a problem hiding this comment.
Not sure, not fully aware what might be. May be we can leave as is and later change if any problem arises?
There was a problem hiding this comment.
I'll ping @TorstenDittmann about it.
There was a problem hiding this comment.
removed this for now
src/CLI/Task.php
Outdated
| @@ -40,7 +20,7 @@ class Task | |||
| * | |||
| * @var array | |||
| */ | |||
| protected $labels = []; | |||
| protected array $labels = []; | |||
There was a problem hiding this comment.
Don't we get this from the Hook class? I think we should.
There was a problem hiding this comment.
We don't have it in hook, it doesn't make sense in hook does it? What would we use labels in hook for?
There was a problem hiding this comment.
We can use labels for whatever we want, and it seems like it might be repetitive across servers.
There was a problem hiding this comment.
labels now in hooks
No description provided.