-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Code Linter To ‘utopia-php/cli #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vasucp1207 Great PR! 🤯 Looks like there are issues detected by pint. Please fix the issues so that the GitHub action will pass:
gitpod /workspace/cli (linter) $ docker run --rm --interactive --tty --volume $PWD:/app composer lint
> ./vendor/bin/pint --test
⨯⨯⨯⨯⨯⨯⨯
───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── Laravel
FAIL ............................................................................................................ 7 files, 7 style issues
⨯ src/CLI/CLI.php braces, curly_braces_position, concat_space, single_quote, Laravel/laravel_phpdoc_order, Laravel/laravel_phpdoc_separation…
⨯ src/CLI/Console.php no_unneeded_control_parentheses, concat_space, single_quote, whitespace_after_comma_in_array, not_operator_with_succes…
⨯ src/CLI/Task.php class_attributes_separation, braces, curly_braces_position, Laravel/laravel_phpdoc_separation, no_unused_imports, Laravel…
⨯ tests/CLI/CLITest.php braces, function_declaration, curly_braces_position, concat_space, ordered_imports
⨯ tests/CLI/ConsoleTest.php concat_space, ordered_imports
⨯ tests/CLI/TaskTest.php braces, curly_braces_position, multiline_whitespace_before_semicolons, ordered_imports
⨯ tests/resources/loop.php braces, curly_braces_position, concat_space
Script ./vendor/bin/pint --test handling the lint event returned with error code 1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey 👋 awesome work on your PR! We've approved your work and it'll be merged soon!
@vasucp1207 The tests are failing. Please run and fix all the linter issues and update the PR |
@christyjacob4, I think the tests are failing due to the linter check. |
@christyjacob4, it looks like travis is using
|
THANK YOU! All changes merged 🥳 Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord. You can accept the invite by visiting https://github.com/orgs/appwrite/invitation. By joining our team, you will officially be an Appwrite maintainer on GitHub. You can change your membership visibility settings, so your new Appwrite team membership badge will show up on your personal GitHub profile. Please feel free to look for more PRs you might be interested in helping with on our long list of Hacktoberfest friendly issues and help make Appwrite better :) |
PR related to this issue.