fix: improve execute error #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -584,7 +584,7 @@ public function execute( | |||
|
|
|||
| $parsedResponse = json_decode($result['response'], true); | |||
| if ($parsedResponse['Running'] === true || $parsedResponse['ExitCode'] !== 0) { | |||
| throw new Orchestration('Failed to execute command: '.$result['response'].' Exit Code: '.$parsedResponse['ExitCode']); | |||
| throw new Orchestration('Failed to execute command. Exit code: '.$parsedResponse['ExitCode']); | |||
There was a problem hiding this comment.
Since we're removing the docker API error message, can we make this error message more verbose like how to debug or what are the likely causes of this failure?
There was a problem hiding this comment.
The only reason this will be thrown is if the user provided build script does not completely successfully. Which is written to the $output reference, there's not really any more detail needed imo
loks0n
requested review from
vermakhushboo and
christyjacob4
and removed request for
christyjacob4
vermakhushboo
approved these changes
Jul 16, 2024
christyjacob4
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Executor is throwing error that includes docker API response:
Instead, we should just show the failed build logs.