Hotfix/enforce local #173
Merged
Hotfix/enforce local #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CedNaru
reviewed
Apr 23, 2021
| jint result{JvmLoader::get_create_jvm_function()(&java_vm, reinterpret_cast<void**>(&jni_env), &args)}; | ||
|
|
||
| #ifndef NO_USE_STDLIB | ||
| std::locale::global(global); |
There was a problem hiding this comment.
Just add a small comment about why we are doing that so we don't forget in future reworks
There was a problem hiding this comment.
Best would be with link to the corresponding issue
CedNaru
reviewed
Apr 23, 2021
chippmann
requested changes
Apr 23, 2021
| jint result{JvmLoader::get_create_jvm_function()(&java_vm, reinterpret_cast<void**>(&jni_env), &args)}; | ||
|
|
||
| #ifndef NO_USE_STDLIB | ||
| std::locale::global(global); |
There was a problem hiding this comment.
Best would be with link to the corresponding issue
chippmann
approved these changes
Apr 24, 2021
CedNaru
approved these changes
Apr 24, 2021
raniejade
approved these changes
Apr 25, 2021
chippmann
force-pushed
the
hotfix/enforce-local
branch
from
3b82206 to
1337cd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #166
This resolves #170