-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/godot 3.3.0 #174
Merged
Merged
Feature/godot 3.3.0 #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chippmann
requested changes
Apr 23, 2021
b428f37
to
276e41e
Compare
chippmann
approved these changes
Apr 25, 2021
raniejade
approved these changes
Apr 25, 2021
docs/src/doc/versioning.md
Outdated
@@ -1,7 +1,7 @@ | |||
The module uses semantic versioning for its own versions but adds a suffix for the supported godot version: | |||
|
|||
Full version: `0.1.0-3.2.3` | |||
Full version: `0.1.0-3.3.0` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I don't think its scalable to change this documentation every time we bump the engine version. The versions here are examples only, so this specific change is unnecessary.
CedNaru
approved these changes
Apr 25, 2021
51d9083
to
4b50728
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates module to Godot 3.3.
Please test it carefully on your side before we merge it.