Rename node helpers #187
Rename node helpers #187
Conversation
| inline fun <T : Node> Node.node(path: String) = getNode(NodePath(path)) as T? | ||
|
|
||
| @Suppress("NOTHING_TO_INLINE", "UNCHECKED_CAST") | ||
| inline fun <T : Node> Node.node(nodePath: NodePath) = getNode(nodePath) as T? |
There was a problem hiding this comment.
Why is the rename necessary? It works for me if they just have a different package path.
There was a problem hiding this comment.
It works for getNode(String) but not for getNode(NodePath) in my case.
There was a problem hiding this comment.
it's suggested but when I select it, it still doesn't work, the import is not made so I just get a red line.
There was a problem hiding this comment.
might be good to test out latest kotlin versions and enabling JVM IR - from what I understand the code still compiles but the only IDE marks it as red?
|
I just did a test, moving to a different package only hides the issue - when you start using the helpers the problem can occur - so a rename is a must. I think we need a way to tell the helper is connected to |
|
Hmm weird. I dont seem to have those issues. Anyways. Then I'm all in for either just |
|
|
|
GetNodeAs seems nice, it creates a whole sentence that way |
Extensions are now in their own package and I split them into 2 files, one for Object, one for Node.
Also because of a conflict with the "getNode" name, the helpers have been rename simple "node".
related issue : #183