fix: Getter now calls method from parent even if getter starts with is #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piiertho
force-pushed
the
feature/api-gen/getter-call-parent-method-if-exists
branch
from
edff85c to
8bd2d00
Compare
chippmann
requested changes
Jun 11, 2021
kt/api-generator/src/main/kotlin/godot/codegen/generationEntry.kt
Outdated
Show resolved
Hide resolved
piiertho
changed the title
|
@JvmName should be your friend. |
piiertho
force-pushed
the
feature/api-gen/getter-call-parent-method-if-exists
branch
from
8bd2d00 to
e66dbe3
Compare
…ter which rely on super implementation will not be visible from java
piiertho
force-pushed
the
feature/api-gen/getter-call-parent-method-if-exists
branch
from
e66dbe3 to
b77d587
Compare
chippmann
approved these changes
Jun 12, 2021
CedNaru
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated getters were not calling parent method if method was starting with
is.This resolves #216