Fix android build #249
Merged
Fix android build #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CedNaru
reviewed
Jul 26, 2021
CedNaru
reviewed
Jul 26, 2021
CedNaru
reviewed
Jul 26, 2021
...ugins/godot-gradle-plugin/src/main/kotlin/godot/gradle/setupConfigurationsAndCompilations.kt
Outdated
Show resolved
Hide resolved
CedNaru
reviewed
Jul 26, 2021
...ugins/godot-gradle-plugin/src/main/kotlin/godot/gradle/setupConfigurationsAndCompilations.kt
Show resolved
Hide resolved
CedNaru
approved these changes
Jul 26, 2021
This part created default value instances and destroyed them immediately. IIRC this part of the code was from the time we stored the actual default value instance in the registration code rather than having a provider like we do now
piiertho
approved these changes
Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the android build by using the newer
d8tool rather than the deprecateddxtool.This also has the advantage of smaller resulting jars, as the unnecessary
classfiles are not bundled into it.Just the
classes.dexfile (and the service file in the case ofmain-dex.jar).One config field was added to the
godotconfig block:androidCompileSdkDir. As theandroid.jarcontained in that dir, is needed by thed8tool. The path to that dir depends on the target compilation sdk version. In most cases this is the most recent sdk version. Corresponding documentation was added.Please test this especially on windows, as I'm unsure if the gradle task
createMainDexJaris properly configured for windows.