Feature/graal support #256
Conversation
piiertho
force-pushed
the
feature/graal-support
branch
from
f89a3de to
f8f1d0a
Compare
src/jni/jvm.h
Outdated
| @@ -10,24 +10,32 @@ namespace jni { | |||
|
|
|||
| class Jvm { | |||
| public: | |||
| enum Type { | |||
| HOTSPOT, | |||
| GRAAL, | |||
There was a problem hiding this comment.
I think it's confusing to use Graal for native images as you could also use Graal as a regular JVM, which in this case would fit in the Hotspot value.
Maybe JVM, NATIVE, and ART ?
There was a problem hiding this comment.
Instead of NATIVE, maybe something more specific - NATIVE_IMAGE.
There was a problem hiding this comment.
JVM, NATIVE_IMAGE and ART, is everyone ok with this ?
There was a problem hiding this comment.
I would even opt for GRAAL_NATIVE_IMAGE to be very specific. IMO NATIVE_IMAGE is a bit generic
...ugins/godot-gradle-plugin/src/main/kotlin/godot/gradle/setupConfigurationsAndCompilations.kt
Outdated
Show resolved
Hide resolved
...ugins/godot-gradle-plugin/src/main/kotlin/godot/gradle/setupConfigurationsAndCompilations.kt
Outdated
Show resolved
Hide resolved
...ugins/godot-gradle-plugin/src/main/kotlin/godot/gradle/setupConfigurationsAndCompilations.kt
Show resolved
Hide resolved
|
I would also add your statement |
kt/plugins/godot-gradle-plugin/src/main/kotlin/godot/gradle/GodotExtension.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
One last comment, but that's nitpicking so up to you if you want to do it as well.
Awesome work! At one point it maybe would make sense to write a little section in the knowledge base regarding the usage of graalvm native image for contributors but that's not very important now.
| !!! warning | ||
| GraalVM native image is a advanced feature and requires a lot of work to support. Especially if you rely on many third party libraries. | ||
|
|
||
| In order to build for graalvm, follow `GraalVM native-image` section in advanced user guide. |
There was a problem hiding this comment.
One tiny thing: I would link the corresponding page here: GraalVM native image
piiertho
force-pushed
the
feature/graal-support
branch
from
01ecc1c to
d6548f0
Compare
This adds GraalVM native image support.
This adds to Gradle plugin option to generate GraalVM native image.
This adds command line argument
--java-vm-type.This adds godot kotlin specific project configuration file
godot_kotlin_configuration.json.Currently platforms supported are Windown, Linux and MacOS, on AMD64 hosts.
Warning: Reloading is not possible with native-image, as it would require to reload JVM.