Show warning when JAVA_HOME is not defined #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raniejade
reviewed
Aug 19, 2021
piiertho
requested changes
Aug 21, 2021
…use them from within the editor plugin
piiertho
requested changes
Aug 21, 2021
CedNaru
approved these changes
Aug 21, 2021
piiertho
approved these changes
Aug 24, 2021
piiertho
requested changes
Aug 24, 2021
chippmann
deleted the
feature/133_dont_crash_when_java_home_not_defined
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #133
This prevents our module from loading if JAVA_HOME is not defined in editor mode instead of letting the editor crash.
It also adds a warning on editor startup about the issue: