Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: enable to set android min api #295

Merged
merged 2 commits into from
Nov 30, 2021

Conversation

piiertho
Copy link
Member

Add androidMinApi parameter to gradle plugin to enable specify --min-api argument of d8 tool

@CedNaru
Copy link
Member

CedNaru commented Nov 28, 2021

Maybe we can also add the multidex in this PR as well as it's a closely related matter.

@piiertho
Copy link
Member Author

Maybe we can also add the multidex in this PR as well as it's a closely related matter.

Multidex is a legacy feature for Dalvik.
On art it is enabled by default. (So after Android 21)
https://developer.android.com/studio/build/multidex

CedNaru
CedNaru previously approved these changes Nov 28, 2021
@chippmann
Copy link
Contributor

Maybe we can also add the multidex in this PR as well as it's a closely related matter.

Multidex is a legacy feature for Dalvik. On art it is enabled by default. (So after Android 21) https://developer.android.com/studio/build/multidex

Still we need to handle that. AFAIK the d8 tool will generate multiple dex files. Currently we then only add the main dex file to the exported game together with the bootstrap dex file.
But not the other dex files.
But i suggest doing this in a separate PR.

chippmann
chippmann previously approved these changes Nov 29, 2021
@piiertho
Copy link
Member Author

Maybe we can also add the multidex in this PR as well as it's a closely related matter.

Multidex is a legacy feature for Dalvik. On art it is enabled by default. (So after Android 21) https://developer.android.com/studio/build/multidex

Still we need to handle that. AFAIK the d8 tool will generate multiple dex files. Currently we then only add the main dex file to the exported game together with the bootstrap dex file. But not the other dex files. But i suggest doing this in a separate PR.

I dont think so.
We generate dex files that will be zipped into one jar.
We should not confuse dex files and jar zipping them.

@piiertho piiertho dismissed stale reviews from chippmann and CedNaru via 1ecf31a November 29, 2021 17:11
@CedNaru CedNaru self-requested a review November 30, 2021 17:02
@piiertho piiertho merged commit 0b593d5 into master Nov 30, 2021
@piiertho piiertho deleted the feature/enable-to-set-android-min-api branch November 30, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants