Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update to godot 3.4.2 #298

Merged
merged 1 commit into from
Jan 9, 2022
Merged

Conversation

piiertho
Copy link
Member

This updates module to 3.4.2 version of godot.

@piiertho piiertho self-assigned this Dec 26, 2021
@piiertho piiertho force-pushed the feature/update-to-godot-3.4.2 branch 2 times, most recently from 5e16a77 to 510596c Compare December 26, 2021 14:54
@piiertho piiertho changed the base branch from develop to master December 26, 2021 16:11
Copy link
Contributor

@chippmann chippmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing we forgot to update each time and needs correcting: here the version is still wrong: https://godot-kotl.in/en/stable/contribution/setup/

Just as a note: remember to move the stable tag so the website get's updated. :-)

@piiertho
Copy link
Member Author

One thing we forgot to update each time and needs correcting: here the version is still wrong: https://godot-kotl.in/en/stable/contribution/setup/

Just as a note: remember to move the stable tag so the website get's updated. :-)

IIRC CI updates stable tag when releasing

@chippmann
Copy link
Contributor

One thing we forgot to update each time and needs correcting: here the version is still wrong: https://godot-kotl.in/en/stable/contribution/setup/
Just as a note: remember to move the stable tag so the website get's updated. :-)

IIRC CI updates stable tag when releasing

Yeah it should but IIRC it does not work reliably. Didn't we have some problems with it in the past? When i look at our current documentation website, it doesn't seem up to date to me? For example see the version here: https://godot-kotl.in/en/stable/user-guide/versioning/

@piiertho
Copy link
Member Author

One thing we forgot to update each time and needs correcting: here the version is still wrong: https://godot-kotl.in/en/stable/contribution/setup/

Just as a note: remember to move the stable tag so the website get's updated. :-)

IIRC CI updates stable tag when releasing

Yeah it should but IIRC it does not work reliably. Didn't we have some problems with it in the past? When i look at our current documentation website, it doesn't seem up to date to me? For example see the version here: https://godot-kotl.in/en/stable/user-guide/versioning/

True, did not catch this. But stable tag is up to date :/

@chippmann
Copy link
Contributor

One thing we forgot to update each time and needs correcting: here the version is still wrong: https://godot-kotl.in/en/stable/contribution/setup/

Just as a note: remember to move the stable tag so the website get's updated. :-)

IIRC CI updates stable tag when releasing

Yeah it should but IIRC it does not work reliably. Didn't we have some problems with it in the past? When i look at our current documentation website, it doesn't seem up to date to me? For example see the version here: https://godot-kotl.in/en/stable/user-guide/versioning/

True, did not catch this. But stable tag is up to date :/

Probably we need to set the stable tag before the actual version tag?

@piiertho
Copy link
Member Author

That's what we do already IIRC

@piiertho piiertho force-pushed the feature/update-to-godot-3.4.2 branch from 510596c to 87a56dd Compare December 30, 2021 20:48
@piiertho piiertho requested a review from chippmann December 31, 2021 10:40
chippmann
chippmann previously approved these changes Jan 3, 2022
CedNaru
CedNaru previously approved these changes Jan 9, 2022
@piiertho piiertho dismissed stale reviews from CedNaru and chippmann via f208d0d January 9, 2022 11:50
@piiertho piiertho force-pushed the feature/update-to-godot-3.4.2 branch from 87a56dd to f208d0d Compare January 9, 2022 11:50
@piiertho piiertho requested review from chippmann and CedNaru January 9, 2022 12:05
@piiertho piiertho merged commit d52584d into master Jan 9, 2022
@piiertho piiertho deleted the feature/update-to-godot-3.4.2 branch January 9, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants