Fix Basis(), Basis#isOrthogonal, Basis#isEqualApprox

[richardtreier]

basis.getRotationQuat() and basis.orthonormalized().getQuat() are currently throwing

java.lang.IllegalArgumentException: Basis must be normalized in order to be casted to a Quaternion. Use get_rotation_quat() or call orthonormalized() instead.

[piiertho]

Hello @richardtreier, thanks for the bugfix. Can you add a test to check this, so that we avoid regression ?

[richardtreier]

I added some tests, however, am currently unable to run them, so I hope to test them in the pipeline.

[chippmann]

LGTM
The NIT comment would be a nice to have, but I'm happy without it as well.

Thanks a lot for fixing this issue!

[richardtreier]

I got tests running (with godot/3.3), and test_coretypes_basis.gd passed. I am not getting any wiser from the pipeline results here, however, do they include the full tests?

[piiertho]

CI is failing because you can't access PGP key to sign gradle plugin.
That's on our side.
Tests are passing :)