Fix entry generation for classes implementing custom interfaces with registered members #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piiertho
previously approved these changes
Nov 19, 2022
Sub sequentially this also increases the amount of data the entry generator receives in order to do its job. Previously it only received registered classes, functions, properties and constructors. Now it receives every class, function and property from the symbol processor. This allows for additional checks on not registered members or not explicitly registered members.
… property is registered
chippmann
force-pushed
the
bugfix/#371
branch
from
97842de to
1a4f69b
Compare
CedNaru
approved these changes
Nov 27, 2022
piiertho
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the entry generation for classes which implement custom interfaces.
Sub sequentially this also increases the amount of data the entry generator receives in order to do its job. Previously it only received registered classes, functions, properties and constructors. Now it receives every class, function and property the symbol processor finds. This allows for additional checks on not registered members or not explicitly registered members.
This also adds compiler checks for the cases where any member overrides a registered member of a supertype but is itself not registered. These checks only emit warnings as this might be wanted by the developer in some cases.
This also fixes an inconsistency where we previously enforces overridden registered functions to be explicitly registered as well, but we did not enforce the same for properties. This is now the case and produces both compiler and IDE warnings in these cases
Note:Before review: Please take a look at the discussion regarding the registration enforcement changes on Discord in the
#developmentchannel. Once we make a decision I'll document it here.Edit: For now we enforce registration for overridden members.
Resolves #371