Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.0/fix compilation errors #377

Merged
merged 34 commits into from
Nov 22, 2022
Merged

4.0/fix compilation errors #377

merged 34 commits into from
Nov 22, 2022

Conversation

chippmann
Copy link
Contributor

@chippmann chippmann commented Nov 15, 2022 •
edited
Loading

Make our code compile with the changes from the latest master (245e6454a03a24bf074eb3715776125842e3b666)

@chippmann chippmann added the GD4 label Nov 15, 2022
@chippmann
Copy link
Contributor Author

The checks now pass as well. The only one not passing are the actual tests as the entry gen still produces wrong code which is fixed with #369. Hence i won't fix it here.

@chippmann
Fix compilation errors in export plugin
7bd5e69
@chippmann
Comment rpc stuff fixes in #369
1b52601
@chippmann
Replace plus_file with path_join. See: godotengine/godot#65066
04f505b
@chippmann
Replace call with callp and call_deferred witch `call_deferredp…
5b9d4c1 
…`. See: godotengine/godot@d4433ae
@chippmann
Replace Main::is_project_manager() with `Engine::get_singleton()->i…
8388d79 
…s_project_manager_hint()`. See: godotengine/godot#52742
@chippmann
Fix save overridden method structure
ed19b68
@chippmann
Add overrides for new pure virtual functions
cf1efb4
@chippmann
Add overrides for missing pure virtual functions
4bb47e2
@chippmann
Fix bottom panel
60c3ed8
@chippmann
Fix import and tooltip
5a77dea
@chippmann
Implement missing function
6e74fc7
@chippmann
Make KotlinEditorExportPlugin header only to make it compile. See: …
c203757 
…`GDExtensionExportPlugin`
@chippmann
Fix godot actions input
1be6a58
@chippmann
Fix wrong arch input
02628f5
@chippmann
Rename osx to macos for platform input
913fc6a
@chippmann
Rename job matrix name for macos targets
f812fc2
@chippmann
Remove remaining tools inputs
a3ed677
@chippmann
Add setup vulkan sdk
1176953
@chippmann
Fix target
25b273f
@chippmann
Replace all occurrences of osx with macos
7fafede
@chippmann
Replace OSX_ENABLED with MACOS_ENABLED
a33f313
@chippmann
Rename directory
b12ef1c
@chippmann
Fix x86_64 binary name
5621784
@chippmann
Fix android export template builds
4bb8497
@chippmann chippmann force-pushed the 4.0/fix_compilation_errors branch from f60d99a to 63d7d5b Compare November 16, 2022 09:06
@piiertho piiertho force-pushed the 4.0/fix_compilation_errors branch from cf4febd to f10089b Compare November 17, 2022 08:25
piiertho
piiertho reviewed Nov 18, 2022
View reviewed changes
src/kt_custom_callable.h Outdated Show resolved Hide resolved
piiertho
piiertho approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@piiertho piiertho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few typo, otherwise ok for me, thx a lot !

@chippmann chippmann merged commit 6350f19 into 4.0-adaptation Nov 22, 2022
@chippmann chippmann deleted the 4.0/fix_compilation_errors branch November 22, 2022 13:09
@chippmann chippmann mentioned this pull request Nov 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piiertho piiertho piiertho approved these changes

@CedNaru CedNaru CedNaru approved these changes

@raniejade raniejade Awaiting requested review from raniejade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chippmann @CedNaru @piiertho