Fix constructor with generic args registration #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piiertho
approved these changes
Dec 3, 2022
CedNaru
approved these changes
Dec 5, 2022
chippmann
deleted the
bugfix/fix_constructor_with_multiple_args_registration
branch
chippmann
added a commit
that referenced
this pull request
Mar 24, 2023
* Fix registration of constructors with multiple args * Add test class (cherry picked from commit 6384dc4)
chippmann
added a commit
that referenced
this pull request
Mar 25, 2023
* Fix typo in your-first-class doc (#378) * Generate `.gdignore` files for the `build` and the `gradle` directories (#366) * Add task to generate `.gdignore` files for the `build` and the `gradle` directories * Improve task setup and add jre folders to ignored folders * Implement generics check (#375) This check verifies that the user does not try to register any generic types as these won't compile * enh: Move jvm types registration code from GDKotlin to TypeManager (#357) * Export android x86_64 target (#381) * Export android x86_64 target * Fix path for debug builds (cherry picked from commit b57ab94) # Conflicts: # .github/actions/create-android-export-template/action.yaml # .github/workflows/check-pr-engine-export-template-debug.yaml # .github/workflows/check-pr-engine-export-template-release.yaml # .github/workflows/deploy-export-template.yaml * Improve changelog header to be more explict about which files are for what (#392) (cherry picked from commit c741582) * Fix constructor with generic args registration (#396) * Fix registration of constructors with multiple args * Add test class (cherry picked from commit 6384dc4) * Fix reflection usage in usercode (#452) * Add `kotlin-reflect` dependency to godot-library * Temporarily fix scons version * Add graal reflection configuration file option and update comment on existing option * Add additional graal options needed for reflection to work and also commit the standard configuration for kotlin-reflection (cherry picked from commit c273de5) --------- Co-authored-by: Cristian Heitt <[email protected]> Co-authored-by: Pierre-Thomas Meisels <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The registration of constructors which have generic type parameters like
Dictionarywas broken.The following class:
produced the following invalid constructor registration:
The reason was that i forgot to add
,for generic type parameters while assembling the kotlin poet template for the constructor registration. This PR fixes this.