Avoid singletons check when gc cleanup #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chippmann
approved these changes
Mar 5, 2023
CedNaru
requested changes
Mar 6, 2023
There was a problem hiding this comment.
Overall I do not like the approach here.
I don't want to transform singletons into an exception in the regular initialization code of the KtObjects.
Something I would do is to create a function initializing all singletons on the JVM side ,that would be called when our module starts, just like we do with the rest of the API when constructors and functions index are set.
piiertho
force-pushed
the
bugfix/avoid-singletons-gc-registration-when-sent-from-cpp-first
branch
from
3bc47c5 to
c423060
Compare
piiertho
force-pushed
the
bugfix/avoid-singletons-gc-registration-when-sent-from-cpp-first
branch
from
c423060 to
96338a1
Compare
piiertho
changed the title
CedNaru
approved these changes
Mar 9, 2023
piiertho
deleted the
bugfix/avoid-singletons-gc-registration-when-sent-from-cpp-first
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid registration of singletons when those are sent from cpp first.
Set ObjectId when constructing singletons.