Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement an LRU cache for StringName objects. #535

Merged
merged 15 commits into from
Dec 8, 2023
Merged

Implement an LRU cache for StringName objects. #535

merged 15 commits into from
Dec 8, 2023

Conversation

apkelly
Copy link
Contributor

@apkelly apkelly commented Nov 8, 2023 •
edited
Loading

A test of my forked repo being able to send PRs to main repo.

Fixing Issue #499

chippmann
chippmann requested changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@chippmann chippmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some unit test would be nice as well. But here again; Personally I'm fine with adding them later as well. I don't want to force work onto volunteers.

That said; thanks a lot for your first contribution!

kt/godot-library/src/main/kotlin/godot/core/bridge/StringName.kt Show resolved Hide resolved
kt/godot-library/src/main/kotlin/godot/core/memory/MemoryManager.kt Outdated Show resolved Hide resolved
@chippmann chippmann added enhancement New feature or request performance Related to performance problem topic:core labels Nov 8, 2023
@apkelly apkelly marked this pull request as draft December 2, 2023 10:42
@apkelly apkelly requested a review from chippmann December 5, 2023 08:27
@apkelly apkelly marked this pull request as ready for review December 5, 2023 08:28
@CedNaru CedNaru requested review from CedNaru and piiertho December 7, 2023 10:12
@CedNaru CedNaru merged commit fc2f3ea into utopia-rise:master Dec 8, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piiertho piiertho piiertho approved these changes

@CedNaru CedNaru CedNaru approved these changes

@chippmann chippmann Awaiting requested review from chippmann

Assignees
No one assigned
Labels
enhancement New feature or request performance Related to performance problem topic:core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apkelly @chippmann @CedNaru @piiertho