fix(entry-gen): escape string correcly on windows in RegisteredClassMetadata and use universal file separators. #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etadata and use universal file separators.
piiertho
force-pushed
the
bugfix/entry-gen/relative-windows-path-in-RegisteredClassMetadata
branch
from
b574609 to
295c4d1
Compare
CedNaru
approved these changes
Nov 16, 2023
piiertho
deleted the
bugfix/entry-gen/relative-windows-path-in-RegisteredClassMetadata
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes master branch on windows.