Improve Env class and its uses #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CedNaru
force-pushed
the
gd_kotlin/reliable_jni_env
branch
from
4c2eabf to
f3a17cd
Compare
CedNaru
force-pushed
the
improvement/jvm_wrapper
branch
from
d22383e to
439973f
Compare
CedNaru
force-pushed
the
gd_kotlin/reliable_jni_env
branch
2 times, most recently
from
d9ceefe to
414697d
Compare
chippmann
approved these changes
Apr 4, 2024
CedNaru
force-pushed
the
gd_kotlin/reliable_jni_env
branch
from
414697d to
bc30811
Compare
piiertho
approved these changes
Apr 5, 2024
CedNaru
added a commit
that referenced
this pull request
Apr 30, 2024
CedNaru
added a commit
that referenced
this pull request
May 7, 2024
CedNaru
added a commit
that referenced
this pull request
May 8, 2024
CedNaru
added a commit
that referenced
this pull request
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed an issue with the Env stored in the Jvm not being thread dependent, which could cause memory leak when multithread was used.
On top of that. I removed as many
jni::Jvm::current_env()as possible. Opting to pass its reference to the deepest part of the api.Most calls to that function now are going to be in the overridden Godot methods (like in Script or ScriptInstance).
I couldn't remove the use of it in destructors as they have no parameters.