Make VariantArray and Dictionary constructors visible to Java #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CedNaru
changed the title
CedNaru
force-pushed
the
java/make_array_dict_constructors_visible
branch
from
1f0fc90 to
4b5143e
Compare
piiertho
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just discovered from a Discord conversation that it was not possible to create a new VariantArray and Dictionary from Java.
They both require a KClass which is a Kotlin STD object and the fake constructor we use for it is inlined when the actual one is internal. Inline functions are not visible from Java.
I created a new public constructor that directly take Java classes as arguments. Boilerplate to use, but we have no choice.