Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix template usage #713

Merged
merged 7 commits into from
Oct 7, 2024
Merged

Fix template usage #713

merged 7 commits into from
Oct 7, 2024

Conversation

CedNaru
Copy link
Member

@CedNaru CedNaru commented Oct 4, 2024

Currently, the editor is not able to automatically use our templates because there is a mismatch between its name and the name of the template. We have so far build our custom editor using the same "name" as the official godot, which creates a conflict.

I made the changes so that the next release is going to use the name 4.3.stable.jvm.0.11.0.
We can't change the prefix 4.3-stable unless we directly Godot files, but we can append anything we want to it, so I picked jvm.ourcurrentversion

Without that change, users can't properly export without manually setting a release and a debug export template in their export preset.
This issue didn't happened before because we were using the same name as the official template for ours. I changed last before the last release so people could have both the official and the koltin versions of a template without name conflict. I just didn't realise that the editor name had to exactly the template to work..

So it's either this change or we revert all names to the same as the official release, preventing users to use both Kotlin and non kotlin versions of the templates.

Note that because, this PR changes the names of the build, opening the template manager create this warning:
image
It doesn't prevent anything, it's just an annoying warning because the editor is hardcoded to search the official godot website.

I created a proposal that would allow us to set a link to our GitHub, so users can download templates directly from there:
godotengine/godot-proposals#10894

@CedNaru CedNaru requested review from chippmann and piiertho October 4, 2024 05:28
@CedNaru CedNaru force-pushed the fix/default_export_template branch 2 times, most recently from a87b354 to 5c2ee57 Compare October 4, 2024 06:26
piiertho
piiertho previously approved these changes Oct 4, 2024
Copy link
Contributor

@chippmann chippmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add why the warning appears to the docs and possibly link to your proposal as well as part of the explanation.

@CedNaru CedNaru requested a review from chippmann October 4, 2024 07:09
@CedNaru CedNaru force-pushed the fix/default_export_template branch 2 times, most recently from 9cf25c0 to 0df5b31 Compare October 5, 2024 14:27
@piiertho
Copy link
Member

piiertho commented Oct 5, 2024

Why CI is failing on test export ?

@CedNaru CedNaru force-pushed the fix/default_export_template branch 3 times, most recently from e08a7ba to 076cfc4 Compare October 6, 2024 00:04
@CedNaru CedNaru requested a review from piiertho October 6, 2024 06:40
piiertho
piiertho previously approved these changes Oct 6, 2024
chippmann
chippmann previously approved these changes Oct 7, 2024
Copy link
Contributor

@chippmann chippmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit. I leave it up to you if you want to change that or not.

docs/src/doc/user-guide/exporting.md Outdated Show resolved Hide resolved
@CedNaru CedNaru dismissed stale reviews from chippmann and piiertho via f464aae October 7, 2024 08:58
@CedNaru CedNaru force-pushed the fix/default_export_template branch from 076cfc4 to f464aae Compare October 7, 2024 08:58
@CedNaru CedNaru merged commit 33e5c85 into master Oct 7, 2024
2 of 3 checks passed
@CedNaru CedNaru deleted the fix/default_export_template branch October 7, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants