-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix template usage #713
Fix template usage #713
Conversation
a87b354
to
5c2ee57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add why the warning appears to the docs and possibly link to your proposal as well as part of the explanation.
9cf25c0
to
0df5b31
Compare
Why CI is failing on test export ? |
e08a7ba
to
076cfc4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit. I leave it up to you if you want to change that or not.
076cfc4
to
f464aae
Compare
Currently, the editor is not able to automatically use our templates because there is a mismatch between its name and the name of the template. We have so far build our custom editor using the same "name" as the official godot, which creates a conflict.
I made the changes so that the next release is going to use the name
4.3.stable.jvm.0.11.0
.We can't change the prefix
4.3-stable
unless we directly Godot files, but we can append anything we want to it, so I pickedjvm.ourcurrentversion
Without that change, users can't properly export without manually setting a release and a debug export template in their export preset.
This issue didn't happened before because we were using the same name as the official template for ours. I changed last before the last release so people could have both the official and the koltin versions of a template without name conflict. I just didn't realise that the editor name had to exactly the template to work..
So it's either this change or we revert all names to the same as the official release, preventing users to use both Kotlin and non kotlin versions of the templates.
Note that because, this PR changes the names of the build, opening the template manager create this warning:
It doesn't prevent anything, it's just an annoying warning because the editor is hardcoded to search the official godot website.
I created a proposal that would allow us to set a link to our GitHub, so users can download templates directly from there:
godotengine/godot-proposals#10894