Skip to content

Commit

Permalink
多くのタブ操作を実験的機能に移動
Browse files Browse the repository at this point in the history
  • Loading branch information
utubo committed Nov 12, 2021
1 parent 3f4864a commit 831fb59
Show file tree
Hide file tree
Showing 6 changed files with 26 additions and 10 deletions.
2 changes: 1 addition & 1 deletion src/_locales/en/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
"message": "Previous tab"
},
"newTab": {
"message": "New tab"
"message": "Open a new tab"
},
"newTabUrl": {
"message": "URL"
Expand Down
2 changes: 0 additions & 2 deletions src/content.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ var SimpleGesture = {};
'D-R': 'back',
'R-D': 'top',
'R-U': 'bottom',
'U-L': 'nextTab',
'U-R': 'prevTab',
'D-R-U': 'reload',
'L-D-R': 'close',
'R-D-L': 'newTab',
Expand Down
12 changes: 12 additions & 0 deletions src/experimental.html
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,18 @@
<!-- Pages -->

<div class="page" id="basicGestures">
<div class="item">
<b>Gestures for tab operations</b><br>
<br>
The gestures for tab operations doesn't work well after Firefox for android version 68.
<ul>
<li>nextTab</li>
<li>prevTab</li>
<li>closeAll</li>
<li>closeOthers</li>
<li>closeSameUrl</li>
</ul>
</div>
<div class="item">
<b>SimpleGesture.doCommand()</b><br>
<br>
Expand Down
2 changes: 1 addition & 1 deletion src/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"manifest_version": 2,
"name": "__MSG_extensionName__",
"description": "__MSG_extensionDescription__",
"version": "2.22.7",
"version": "2.23",
"default_locale": "en",
"icons": {
"64": "icon64.png"
Expand Down
6 changes: 3 additions & 3 deletions src/options.html
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@

<div class="page" id="tabGestures">
<div class="page-header i18n">tabGestures</div>
<div class="gesture-list" data-gestures="nextTab prevTab close closeAll closeOthers closeSameUrl newTab"></div>
<div class="gesture-list" data-gestures="nextTab! prevTab! close closeAll! closeOthers! closeSameUrl! newTab"></div>
</div>

<div class="page" id="otherGestures">
Expand Down Expand Up @@ -126,8 +126,8 @@
<div class="custom-gesture-edit button icon-edit"></div>
<div class="custom-gesture-delete button icon-delete"></div>
</div>
<div id="afterClose_item" class="sub-item">
<label for="afterClose" class="sub-caption i18n">afterClose</label>
<div id="afterClose_item" class="sub-item experimental">
<label for="afterClose" class="sub-caption i18n icon-flask">afterClose</label>
<select id="afterClose" class="js-binding">
<option value="" class="caption i18n">default</option>
<option value="prevTab" class="caption i18n">prevTab</option>
Expand Down
12 changes: 9 additions & 3 deletions src/options.js
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@
}
};

const createGestureItem = name => {
const createGestureItem = (name, isExperimental = false) => {
const item = gestureTemplate.cloneNode(true);
item.id = `${name}_item`;
const label = byClass(item, 'udlr');
Expand All @@ -193,6 +193,10 @@
byClass(b, 'custom-gesture-delete').setAttribute('data-targetId', name);
item.insertBefore(b, item.firstChild);
}
if (isExperimental) {
item.classList.add('experimental');
caption.classList.add('icon-flask');
}
return item;
};

Expand All @@ -201,8 +205,10 @@
for (let list of allByClass('gesture-list')) {
const gestures = list.getAttribute('data-gestures');
if (!gestures) continue;
for (let name of gestures.split(/\s+/)) {
list.appendChild(createGestureItem(name));
for (let nameAndOpt of gestures.split(/\s+/)) {
const name = nameAndOpt.replace(/!$/, '');
const isExperimental = nameAndOpt.match(/!$/);
list.appendChild(createGestureItem(name, isExperimental));
gestureNames.push(name);
}
}
Expand Down

0 comments on commit 831fb59

Please sign in to comment.