df: implement the --output command-line argument #3176
Conversation
jfinkels
force-pushed
the
df-output-columns-2
branch
from
de0cb85 to
20365c0
Compare
|
The GNU tests show My hunch is that test was previously passing by accident, since the test script starts with which, before this pull request, would have returned rows with all the default columns instead of rows with just the |
jfinkels
force-pushed
the
df-output-columns-2
branch
2 times, most recently
from
4443950 to
f303426
Compare
jfinkels
force-pushed
the
df-output-columns-2
branch
3 times, most recently
from
aec467d to
c2a77ec
Compare
sylvestre
force-pushed
the
df-output-columns-2
branch
from
c2a77ec to
477a66f
Compare
|
Seems related but a GNU test is failing: |
|
Yes, that is expected. Please see my comment above: #3176 (comment) |
Replace the `Options.show_fs_type` and `Options.show_inode_instead` fields with the more general `Options.columns`, a `Vec` of `Column` variants representing the exact sequence of columns to display in the output. This makes `Options` able to represent arbitrary output column display configurations.
Implement the `--output` command-line argument, which allows
specifying an exact sequence of columns to display in the output
table. For example,
$ df --output=source,fstype | head -n3
Filesystem Type
udev devtmpfs
tmpfs tmpfs
(The spacing does not exactly match the spacing of GNU `df` yet.)
Fixes uutils#3057.
jfinkels
force-pushed
the
df-output-columns-2
branch
from
477a66f to
c0cd017
Compare
|
sorry, I don't know how i missed your comment :( |
This pull request implements the
--outputcommand-line argument, which allows specifying an exact sequence of columns to display in the output table. For example,(The spacing does not exactly match the spacing of GNU
dfyet.)In order to do this, we replace the
Options.show_fs_typeandOptions.show_inode_insteadfields with the more generalOptions.columns, aVecofColumnvariants representing the exact sequence of columns to display in the output. This makesOptionsable to represent arbitrary output column display configurations.Fixes #3057.