df: fix output if input path is a file system #3435
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfinkels
reviewed
Apr 22, 2022
| @@ -68,7 +68,7 @@ where | |||
| path.as_ref().to_path_buf() | |||
| }; | |||
| let matches = mounts.iter().filter(|mi| path.starts_with(&mi.mount_dir)); | |||
| matches.max_by_key(|mi| mi.mount_dir.len()) | |||
| matches.min_by_key(|mi| mi.mount_dir.len()) | |||
There was a problem hiding this comment.
Can you explain why this fixes the problem? I'm not able to figure it out. A comment would be very helpful. Also, the documentation for the function needs to be updated as well.
There was a problem hiding this comment.
I can't explain it. I made a thinking error and concluded from the individual case that it will work in other cases too. Which is not the case. I tried it with another file system on my local system and it didn't work... So I guess my current approach to resolve this issue is flawed and I close this PR. Sorry for wasting your time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example,
df --out=source,target /dev/sda8now shows:instead of
Fixes #3246.