hashsum: Refactor uu_app to isolate non-"GNU Coreutils" options
#3593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
str4d
force-pushed
the
2930-hashsum-isolate-non-gnu-options
branch
from
fbd0d0e to
c2a6ea5
Compare
|
Force-pushed to fix a bug: |
str4d
force-pushed
the
2930-hashsum-isolate-non-gnu-options
branch
from
c2a6ea5 to
e243a26
Compare
|
Force-pushed to fix clippy lints. |
str4d
commented
Jun 5, 2022
Comment on lines
+412
to
+415
| // Needed for variable-length output sums (e.g. SHAKE) | ||
| command.arg( | ||
| Arg::new("bits") | ||
| .long("bits") |
There was a problem hiding this comment.
The core motivation for this refactor is that GNU Coreutils has -l/--length for specifying the output length, which b2sum expects, while --bits is an invalid command on any GNU Coreutils *sum binary. We could simplify this if we removed this flag and instead used -l/--length for sha3sum and shake*sum (if the resolution to #2930 (comment) is to interpret -l/--length as bits), but that would be a breaking change for previous users of coreutils.
Several binaries have been added to `hashsum` that have never been part of GNU Coreutils: - `sha3*sum` (uutils#869) - `shake*sum` (uutils#987) - `b3sum` (uutils#3108 and uutils#3164) In particular, the `--bits` option, and the `--no-names` option added in uutils#3361, are not valid for any GNU Coreutils `*sum` binary (as of Coreutils 9.0). This commit refactors the argument parsing so that `--bits` and `--no-names` become invalid options for the binaries intended to match the GNU Coreutils API, instead of being ignored options. It also refactors the custom binary name handling to distinguish between binaries intended to match the GNU Coreutils API, and binaries that don't have that constraint. Part of uutils#2930.
sylvestre
force-pushed
the
2930-hashsum-isolate-non-gnu-options
branch
from
e243a26 to
fccab8a
Compare
|
thanks and sorry for the latency :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several binaries have been added to
hashsumthat have never been partof GNU Coreutils:
sha3*sum(hashsum: add support for SHA-3 functions #869)shake*sum(hashsum: implement SHAKE-128 and SHAKE-256 #987)b3sum(hashsum: Add BLAKE3 to Hashing Algorithms #3108 and Added b2sum and b3sum utility entries #3164)In particular, the
--bitsoption, and the--no-namesoption added in#3361, are not valid for any GNU Coreutils
*sumbinary(as of Coreutils 9.0).
This commit refactors the argument parsing so that
--bitsand--no-namesbecome invalid options for the binaries intended to matchthe GNU Coreutils API, instead of being ignored options. It also
refactors the custom binary name handling to distinguish between
binaries intended to match the GNU Coreutils API, and binaries that
don't have that constraint.
Part of #2930.