Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort: Fixing opens too many files #5738

Closed

Conversation

allaboutevemirolive
Copy link
Contributor

@allaboutevemirolive allaboutevemirolive commented Dec 28, 2023

Issue #5714 is addressed in this pull request.

Reference:

The same problem can be found in:

To be honest, I am not sure what the exact solution is to this problem. Increasing ulimit, for example, can resolve this issue, as can removing the -m flag from sort -n -m.

This pull request currently requires the user to run the target bash script in sudo mode. Hopefully, the maintainers can incorporate some hints into this PR.:)

@sylvestre
Copy link
Contributor

sorry but i don't think it is the right approach.
Instead, we should investigate where we need to open temporary files and replace it by in memory (or something else) operation

@allaboutevemirolive
Copy link
Contributor Author

allaboutevemirolive commented Dec 28, 2023

Thank you for your feedback. I'll look at ways to fix the issues without changing system resource limits.

Edit: I think digging into cp.rs can give me some hints, and yes, we need to open temporary files and replace them in memory.

Edit: I have an exam coming up in the first month of 2024. Please feel free to create a new PR and close this one. If no new PR is issued, I will investigate this matter in my spare time. :)

@sylvestre
Copy link
Contributor

please reopen when ready

@sylvestre sylvestre closed this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants