chroot: fix many issues with chroot #7057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
Improve the parsing of the `--groups` parameter to `chroot` so that it
handles more error cases and better matches the behavior of GNU
`chroot`. For example, multiple adjacent commas are allowed:
--groups=a,,,b
but spaces between commas are not allowed:
--groups="a, , ,b"
Change the type of `Options.groups` to be `Option<Vec<String>>` so that the absence of the `--groups` option is meaningfully distinguished from an empty list of groups. This is important because `chroot --groups=''` is used specifically to disable supplementary group lookup.
Fix several issues in the behavior of `chroot`, mostly around setting group IDs. This commit ensures that supplemental groups provided by `--groups` are properly handled with respect to the groups implied by `--userspec`. This commit also ensures that we fall back to numeric parsing when attempting to lookup user and group IDs from their names.
jfinkels
force-pushed
the
chroot-set-groups
branch
from
d2a7b1c to
b29d8f1
Compare
|
GNU testsuite comparison: |
|
Three fixes. Wahoo. It is unexpected :) |
|
i guess there isnt a way to reuse some stuff in uucore or to share some code with other programs |
|
Hmm I'm not sure, but I'll definitely keep it in mind if I see some common code that can be refactored. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request fixes several issues in the behavior of
chroot, mostly around settinggroup IDs. It ensures that supplemental groups provided by
--groupsare properly handled with respect to the groups implied by--userspec. It ensures that we fall back to numeric parsing when attempting to lookup user and group IDs from their names.It changes the type of
Options.groupsto beOption<Vec<String>>so thatthe absence of the
--groupsoption is meaningfully distinguished froman empty list of groups. This is important because
chroot --groups=''is used specifically to disable supplementary group lookup.
It improves the parsing of the
--groupsparameter tochrootso that ithandles more error cases and better matches the behavior of GNU
chroot. For example, multiple adjacent commas are allowed:but spaces between commas are not allowed:
This fixes all but one of the test cases in the GNU test file
tests/chroot/chroot-credentials.sh.