.github: CICD: add workspace test to build matrix

[drinkcat]

Add a new Linux build that runs without cross, and adds
--workspace to the cargo test command.

From cargo test documentation, this option "tests all members in
the workspace.". For example, this includes running tests within
the uucore package (see #7383).

Fixes #7392.

[github-actions]

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)

[drinkcat]

Lots of failures, at build time for now...

some ubuntu are missing selinux headers (should be easy to fix):

  selinux-sys: Failed to find 'selinux/selinux.h'. Please make sure the C header files of libselinux are installed and accessible: Kind(NotFound)

Build (ubuntu-latest, i686-unknown-linux-musl, feat_os_unix_musl, use-cross):

error[E0432]: unresolved import `crate::utmpx`
  --> src/uucore/src/lib/features/uptime.rs:93:16
   |
93 |     use crate::utmpx::Utmpx;
   |                ^^^^^ could not find `utmpx` in the crate root
   |
note: found an item that was configured out
  --> src/uucore/src/lib/lib.rs:98:26
   |
98 | pub use crate::features::utmpx;
   |                          ^^^^^

macos, unclear what's the problem exactly:

error: couldn't read /Users/runner/work/coreutils/coreutils/target/aarch64-apple-darwin/debug/build/fts-sys-bdca82aeb17ec986/out/fts-sys.rs: No such file or directory (os error 2)
  --> /Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/fts-sys-0.2.14/src/lib.rs:24:1
   |
24 | include!(concat!(env!("OUT_DIR"), "/fts-sys.rs"));
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: this error originates in the macro `include` (in Nightly builds, run with -Z macro-backtrace for more info)

error: could not compile `fts-sys` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
Error: Process completed with exit code 101.

Windows:

error: failed to run custom build command for `uu_stdbuf_libstdbuf v0.0.29 (D:\a\coreutils\coreutils\src\uu\stdbuf\src\libstdbuf)`
...
  src/libstdbuf.rs(18): error C2065: 'constructor': undeclared identifier
  src/libstdbuf.rs(18): error C2182: '__attribute': this use of 'void' is not valid
  src/libstdbuf.rs(19): error C2146: syntax error: missing ';' before identifier '__stdbuf_init'
  src/libstdbuf.rs(19): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
  src/libstdbuf.rs(21): warning C4508: '__stdbuf_init': function should return a value; 'void' return type assumed

[github-actions]

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)

[github-actions]

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

[github-actions]

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)

[drinkcat]

Thanks for the rebase @sylvestre ,-)

I think this looks good? The uucore tests are being run, at least.

Will look into this one, and clean this up:

Run actions/upload-artifact@v4
With the provided path, there will be 1 file uploaded
Artifact name is valid!
Root directory input is valid!
Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

[github-actions]

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)

[github-actions]

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

[drinkcat]

Should be good, ready for review!

[sylvestre]

it would be nice to document here why we have "workspace-tests"?
(afaik, because it doesn't work well because of cross compil, right)

[drinkcat]

Sure! Added a couple of comments.

[sylvestre]

thanks

out of scope but do you think we should move away from the cross image?

[drinkcat]

Not sure... I'm a bit surprised cross-rs still use 16.04 by default... and... that a new release hasn't happened in 2 years milestone tracking? Development seems active though.

The convenience of cross, and the fact that it's really easy to reproduce CI builds locally, is really nice though...

It is possible to force cross to use a new image though (:main uses 20.04, which is... better already I guess?). It looks like the workspace tests can pass with something like this in Cross.toml:

[build]
pre-build = [
    "dpkg --add-architecture $CROSS_DEB_ARCH", 
    "apt-get update && apt-get --assume-yes install libselinux1-dev:$CROSS_DEB_ARCH"
]
[target.x86_64-unknown-linux-gnu]
image = "ghcr.io/cross-rs/x86_64-unknown-linux-gnu:main"

(the last 2 lines would need to be copy-pasted a few times, I don't see a way to use the :main tag for all targets?! -- and :main syntax is only supported after 0.2.5)

One downside is that the main image is frequently updated, so I guess we'd be at the mercy of upstream breakage, so I think a fixed tag would be slightly safer (we could manually fix a sha if we wanted to, but we'd need to set it for each architecture though, not great in terms of maintenance...)

I think the current solution is still the simplest, and good as a stop-gap at least. But if you want to add --workspace tests for *-musl and i686, we should probably rethink (and check with cross developer on what is blocking a new release).

[github-actions]

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)