-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test main for failure seen in #7378 for Y2038 bug #7399
base: main
Are you sure you want to change the base?
Conversation
71e2c73
to
8efc9ab
Compare
GNU testsuite comparison:
|
GNU testsuite comparison:
|
Those three failures seem like actual failures / y2038 bugs ? Which I'm going to guess ends up in the |
I don't understand why this change is in a separated PR from #7378 |
#7378 test (and fix) compatibility with gnu touch, i.e. that
So really #7378, test the mapping from 2 character years to 4 character years, and could just test This PR tests that dates just before, at, or just after y2038 bug (even when already a 4 character years) get actually written on filesystem with the correct timestamp (they are not on 32 bits systems). So it tests for a potential bug, independently of whether the year is 2 or 4 characters. |
Ok, that makes sense, thanks ! |
It's unclear to me how the failure seen in uutils#7378 is related to the change in the PR, it just happen that the test need to try touching in 2068. The 2^32 error in the test makes me strongly think of the year 2038 bug, so I added a test for that.
It's unclear to me how the failure seen in #7378
is related to the change in the PR, it just happen that the test need to try touching in 2068.
The 2^32 error in the test makes me strongly think of the year 2038 bug, so I added a test for that.