Retrieve multi-processed icesat #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
bpurinton
added a commit
that referenced
this pull request
Nov 26, 2024
#68) This PR lays some foundational groundwork built on top of the multi-processed ICESat-2 retrieval from PR #59. Namely, the `pc_align` functionality has been moved to an `asp_plot.alignment` module in the `Alignment` class. This `Alignment` class is then instantiated from within the `Altimetry` class, allowing the multi-processed ICESat-2 data to spawn several pc_align runs. The results of these pc_align runs on the various temporally processed ICESat-2 points are reported to the user, and, if the translation is above some threshold relative to the DEM's GSD, the alignment is applied. However, when the alignment is applied, the user is notified of any gross disagreements between the translation results for the different time periods of ICESat-2 points used in the alignment, which may indicate unreliable alignment and warrant caution. It is left to the user to decide how to proceed at that point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #40 and #58