Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csm_camera: Update annotation units #66

Merged
merged 2 commits into from
Nov 25, 2024
Merged

csm_camera: Update annotation units #66

merged 2 commits into from
Nov 25, 2024

Conversation

dshean
Copy link
Member

@dshean dshean commented Nov 20, 2024

Fixing issue where 'm' was listed under the angle difference plots

@dshean dshean requested a review from bpurinton November 20, 2024 01:28
@@ -524,7 +525,8 @@ def csm_camera_summary_plot(
linestyle="--",
label="Original Roll",
)
plot_stats_text(ax1_r, cam1_roll_diff_mean, cam1_roll_diff_std)
#Could use unit='°' to save space here
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#Could use unit='°' to save space here

I'm in favor of this if you want to make that update below and elsewhere.

Copy link
Contributor

@bpurinton bpurinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! Looks good to me. I'm going to re-run the test workflow here to make sure this passes before and squash a merge.

@dshean
Copy link
Member Author

dshean commented Nov 20, 2024

Tests are failing due to dg_geom_plot contextily tile issue, unrelated to this PR: https://github.com/uw-cryo/asp_plot/actions/runs/11924954575/job/33270561757#step:6:340

@bpurinton
Copy link
Contributor

Tests are failing due to dg_geom_plot contextily tile issue

Ah, I see. Then we can go ahead and merge this. I'll keep an eye on the issue. The tests pass locally for me on this branch, I just checked to be sure.

@bpurinton bpurinton merged commit 5ae4380 into main Nov 25, 2024
1 check failed
@bpurinton bpurinton deleted the unit_fix branch November 25, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants